Re: [PATCH net-next 1/7] net/mlx5: HWS, Generalize complex matchers

[Vlad Dogaru]

On Wed, Sep 24, 2025 at 05:17:27PM +0100, Simon Horman wrote:
> On Mon, Sep 22, 2025 at 12:01:05PM +0300, Tariq Toukan wrote:
> > From: Vlad Dogaru <vdogaru@xxxxxxxxxx>
> 
> ...
> 
> > +static int hws_complex_subrule_create(struct mlx5hws_bwc_matcher *cmatcher,
> > +				      struct mlx5hws_bwc_rule *subrule,
> > +				      u32 *match_params, u32 flow_source,
> > +				      int bwc_queue_idx, int subm_idx,
> > +				      struct mlx5hws_rule_action *actions,
> > +				      u32 *chain_id)
> >  {
> 
> ...
> 
> > +	ret = mlx5hws_bwc_rule_create_simple(subrule, match_params, actions,
> > +					     flow_source, bwc_queue_idx);
> > +	if (ret) {
> > +		goto put_subrule_data;
> > +		goto unlock;
> 
> Hi Tariq and Vlad,
> 
> I guess it's a simple editing artifact.
> But it seems that the line above is dead code.
> 
> Flagged by Smatch.

Hi Simon,

Thanks for the heads up, will fix in v2.

Cheers,
Vlad