Re: [PATCH v2 02/10] gpu: nova-core: Create initial Gsp
From: John Hubbard
Date: Wed Sep 24 2025 - 16:50:38 EST
On 9/24/25 1:13 PM, Lyude Paul wrote:
> Some comments down below
...
>> +/// Creates a self-mapping page table for `obj` at its beginning.
>> +fn create_pte_array(obj: &mut CoherentAllocation<u8>) {
>> + let num_pages = obj.size().div_ceil(GSP_PAGE_SIZE);
>
> Unfortunately there's a bit of a gotcha here - we can't actually use functions
> like div_ceil as-is, because a number of 32 bit architectures do not support
> u64 / u64 natively. The problem is we don't have __aeabi_uldivmod implemented
I recall that we agreed that nova will depend upon CONFIG_64BIT.
Does that make this point N/A?
thanks,
--
John Hubbard