Re: [PATCH] fs: doc: describe 'pinned' parameter in do_lock_mount()
From: Al Viro
Date: Wed Sep 24 2025 - 16:57:45 EST
On Wed, Sep 24, 2025 at 07:36:11PM +0000, Kriish Sharma wrote:
> The kernel-doc comment for do_lock_mount() was missing a description
> for the 'pinned' parameter:
>
> Warning: fs/namespace.c:2772 function parameter 'pinned' not described
> in 'do_lock_mount'
>
> This patch adds a short description:
>
> @pinned: receives the pinned mountpoint
>
> to fix the warning and improve documentation clarity.
Sigh... There we go again...
1. It does not improve documentation clarity - it adds
a misleading line to an opaque chunk of text that does not match
what the function *does*.
2. In -next both the calling conventions and the comment
are both changed, hopefully making it more readable.
3. Essentially the same patch has already been posted and
discussed.
NAKed-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>