Re: [PATCH net-next v2 5/6] netconsole: resume previously deactivated target
From: Andre Carvalho
Date: Wed Sep 24 2025 - 18:27:14 EST
Hi Breno,
On Wed, Sep 24, 2025 at 01:26:16AM -0700, Breno Leitao wrote:
> The other option is to always populate the mac during netpoll setup and
> then always resume based on mac. This seems a more precise resume.
>
> In this case, if the device goes to DEACTIVATED, then np.dev_mac will be
> populated, and you only compare it to check if you want to resume it.
This sounds good to me. I've done some initial testing patching __netpoll_setup
to always set np->dev_mac, changing maybe_resume_target to simply compare the
mac as you suggested and seems like this approach works.
I'll do more testing and analysis to see if I see any issue with the approach.
If all goes well, I can include these changes in v3. I'll report back in case I
find any problems.