Re: [PATCH v2 07/10] phy: qualcomm: qmp-combo: Update QMP PHY with Glymur settings
From: Wesley Cheng
Date: Wed Sep 24 2025 - 22:14:58 EST
On 9/24/2025 6:30 PM, Dmitry Baryshkov wrote:
On Wed, Sep 24, 2025 at 05:52:25PM -0700, Wesley Cheng wrote:
For SuperSpeed USB to work properly, there is a set of HW settings that
need to be programmed into the USB blocks within the QMP PHY. Ensure that
these settings follow the latest settings mentioned in the HW programming
guide. The QMP USB PHY on Glymur is a USB43 based PHY that will have some
new ways to define certain registers, such as the replacement of TXA/RXA
and TXB/RXB register sets. This was replaced with the LALB register set.
There are also some PHY init updates to modify the PCS MISC register space.
Without these, the QMP PHY PLL locking fails.
Signed-off-by: Wesley Cheng <wesley.cheng@xxxxxxxxxxxxxxxx>
---
drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 311 ++++++++-
.../phy/qualcomm/phy-qcom-qmp-pcs-aon-v6.h | 12 +
.../phy/qualcomm/phy-qcom-qmp-pcs-aon-v8.h | 17 +
.../phy/qualcomm/phy-qcom-qmp-pcs-misc-v5.h | 12 +
.../qualcomm/phy-qcom-qmp-qserdes-lalb-v8.h | 639 ++++++++++++++++++
.../phy/qualcomm/phy-qcom-qmp-usb43-pcs-v8.h | 33 +
.../phy-qcom-qmp-usb43-qserdes-com-v8.h | 224 ++++++
drivers/phy/qualcomm/phy-qcom-qmp.h | 4 +
I think yo've squashed too many changes here. V5 and V6 headers should
be a part of the previous patch.
Hmm, not sure what went wrong there, but I will fix it shortly and
submit as v3.
8 files changed, 1251 insertions(+), 1 deletion(-)
create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcs-aon-v6.h
create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcs-aon-v8.h
create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcs-misc-v5.h
create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-qserdes-lalb-v8.h
create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-usb43-pcs-v8.h
create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-usb43-qserdes-com-v8.h