Re: [PATCH v2 2/2] clocksource/drivers/sh_cmt: Do not power down channels used for events

From: Niklas Söderlund
Date: Thu Sep 25 2025 - 01:12:38 EST


On 2025-09-24 15:46:45 +0200, Geert Uytterhoeven wrote:
> Hi Daniel,
>
> On Wed, 24 Sept 2025 at 15:43, Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> wrote:
> > On 24/09/2025 11:31, Niklas Söderlund wrote:
> > > If it's not too late I think we should drop it. The issue this work
> > > tries to solve is a lockdep blurb which highlights a design issue in the
> > > driver. But the driver have function properly in the past. So I think
> > > it's better I work on solving the blurb without any regressions.
> >
> > Ok, dropping 2/2 but keeping 1/2 is fine, right ?
>
> 1/2 is a refactoring without any functional impact.
> Thanks!

Thanks to the both of you! Geert for testing and finding the regression
and Daniel for his quick action removing it from the pull request. I
will work on a v3 which tries to solve the original issue without the
regression.

>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds

--
Kind Regards,
Niklas Söderlund