Re: [PATCH v2 13/24] arm64: dts: qcom: Update pmh0104 dtsi for Glymur CRD

[Krzysztof Kozlowski]

On Thu, 25 Sept 2025 at 15:29, Pankaj Patil
<pankaj.patil@xxxxxxxxxxxxxxxx> wrote:
>
> From: Kamal Wadhwa <kamal.wadhwa@xxxxxxxxxxxxxxxx>
>
> Update the pmh0104.dtsi to include multiple instances of PMH0104
> DT nodes, one for each SID assigned to this PMIC on the spmi_bus0
> and spmi_bus1 in Glymur CRD board.
>
> Take care to avoid compilation issue with the existing nodes by
> gaurding each PMH0104 nodes with `#ifdef` for its corresponding
> SID macro. So that only the nodes which have the their SID macro
> defined are the only ones picked for compilation.
>
> Signed-off-by: Kamal Wadhwa <kamal.wadhwa@xxxxxxxxxxxxxxxx>
> Signed-off-by: Pankaj Patil <pankaj.patil@xxxxxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/pmh0104.dtsi | 84 +++++++++++++++++++++++++++++++++++
>  1 file changed, 84 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pmh0104.dtsi b/arch/arm64/boot/dts/qcom/pmh0104.dtsi
> index f5393fdebe957ea0caf4bbc16117374b4759bda3..d3ea7486d842ec813a79268fc1466e1513426d78 100644
> --- a/arch/arm64/boot/dts/qcom/pmh0104.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmh0104.dtsi
> @@ -6,7 +6,63 @@
>  #include <dt-bindings/interrupt-controller/irq.h>
>  #include <dt-bindings/spmi/spmi.h>
>
> +&spmi_bus0 {
> +#ifdef PMH0104_I_E0_SID


NAK

I'm surprised you decided to ignore all existing discussions and my
clear point in this.

This is neither readable, nor maintainable.

Please join community in discussing this, instead of coming with
another invention which I already said is poor.

Best regards,
Krzysztof