Re: [PATCH net-next] net: stmmac: Convert open-coded register polling to helper macro

From: Simon Horman

Date: Thu Sep 25 2025 - 05:42:20 EST


On Wed, Sep 24, 2025 at 11:22:17PM +0800, Furong Xu wrote:
> Drop the open-coded register polling routines.
> Use readl_poll_timeout_atomic() in atomic state.
>
> Compile tested only.
> No functional change intended.
>
> Signed-off-by: Furong Xu <0x1207@xxxxxxxxx>

I agree this is correct. Or at least, it looks correct to me.
But, FWIIW, I do have some hesitation about untested code of this nature
being accepted so close to the merge window.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>

...