Re: [PATCH net-next V5] net/mlx5: Improve write-combining test reliability for ARM64 Grace CPUs

From: Patrisious Haddad
Date: Thu Sep 25 2025 - 08:23:02 EST



On 9/25/2025 2:54 PM, Jason Gunthorpe wrote:
On Thu, Sep 25, 2025 at 02:48:33PM +0300, Tariq Toukan wrote:
+static void mlx5_iowrite64_copy(struct mlx5_wc_sq *sq, __be32 mmio_wqe[16],
+ size_t mmio_wqe_size, unsigned int offset)
+{
+#if defined(CONFIG_KERNEL_MODE_NEON) && defined(CONFIG_ARM64)
IS_ENABLED() not defined()
I just wonder why, Is there a preference in the driver from like aesthetic/convention point of view?
Since here it technically doesnt matter - IS_ENABLED have no functional difference from defined since these are boolean configs not *tristate*ones (cant be loaded as module).

Patrisious.

Jason