Re: [PATCH] tools/nolibc: Add stdbool.h to nolibc includes
From: Mark Brown
Date: Thu Sep 25 2025 - 10:45:28 EST
On Thu, Sep 25, 2025 at 11:37:39AM -0300, André Almeida wrote:
> Em 25/09/2025 11:24, Mark Brown escreveu:
> > It's not 100% clear to me that we should add this to the nolibc
> > includes given that nolibc itself does not rely on or offer stdbool -
> > I was going to send something out adjusting kselftest.h to unguard the
> > include there.
>
> If we don't include stdbool.h here, it looks like
> tools/include/nolibc/stdbool.h cannot be used by any test, and unguarding
> <stdbool.h> would defeat the purpose of using -nolibc?
Huh, I'd not seen that - generally stdbool.h comes from the compiler
rather than libc so it didn't occur to me that nolibc would provide one.
Looking at the compilers I have installed they all seem to be doing
essentially the same thing (with some C++ handling).
> I'm also not 100% sure as well, lets see if Thomas or Willy can shine a
> light here.
Yeah, if we've got the nolibc one I guess we should use it in which case
your patch is I guess what's expected. I'll send out my version once my
tests finish just in case.
Attachment:
signature.asc
Description: PGP signature