Re: [PATCH v4 3/3] dt-bindings: max77705: add interrupt-controller property
From: Dmitry Baryshkov
Date: Thu Sep 25 2025 - 16:50:25 EST
On Thu, Sep 25, 2025 at 10:38:39PM +0300, Dzmitry Sankouski wrote:
> Add interrupt-controller property, because max77705 has dedicated interrupt
> source register to determine which sub device triggered an interrupt.
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@xxxxxxxxx>
> ---
> Changes in v4:
> - fix commit message: node -> property
> - fix commit message: minor reword and punctuation
> ---
> Documentation/devicetree/bindings/mfd/maxim,max77705.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml b/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml
> index 0ec89f0adc64..d265c8213a08 100644
> --- a/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml
> +++ b/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml
> @@ -26,6 +26,18 @@ properties:
> interrupts:
> maxItems: 1
>
> + interrupt-controller:
> + description:
> + The driver implements an interrupt controller for the sub devices.
> + The interrupt number mapping is as follows
> + 0 - charger
> + 1 - topsys
> + 2 - fuelgauge
> + 3 - usb type-c management block.
> +
> + '#interrupt-cells':
> + const: 1
> +
> haptic:
> type: object
> additionalProperties: false
> @@ -120,8 +132,10 @@ examples:
> reg = <0x66>;
> interrupt-parent = <&pm8998_gpios>;
> interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-controller;
> pinctrl-0 = <&chg_int_default>;
> pinctrl-names = "default";
> + #interrupt-cells = <1>;
The same: please group them together.
>
> leds {
> compatible = "maxim,max77705-rgb";
>
> --
> 2.39.5
>
--
With best wishes
Dmitry