Re: [PATCH v3 01/16] x86/tdx: Move all TDX error defines into <asm/shared/tdx_errno.h>
From: Edgecombe, Rick P
Date: Thu Sep 25 2025 - 19:23:19 EST
On Fri, 2025-09-19 at 01:29 +0000, Huang, Kai wrote:
> The existing asm/shared/tdx.h is used for sharing TDX code between the
> early compressed code and the normal kernel code after that, i.e., it's
> not for sharing between TDX guest and host.
>
> Any reason to put the new tdx_errno.h under asm/shared/ ?
Well this series doesn't address this, but the compressed code could use
IS_TDX_SUCCESS(), etc. I assume the purpose was to put it in a place where all
callers could use them.
If you think that is good reasoning too, then I think it's worth mentioning in
the log.