Re: [PATCH v3] once: fix race by moving DO_ONCE to separate section
From: Nathan Chancellor
Date: Thu Sep 25 2025 - 20:20:01 EST
On Thu, Sep 25, 2025 at 08:14:35AM +0200, Arnd Bergmann wrote:
> I hadn't seen this until your ping and had a look since it
> touches asm-generic. The patch looks correct to me, thanks for
> addressing this and for the detailed patch description.
Agreed, I am not super familiar with this infrastructure but this seems
correct from my basic understanding.
> I think what happened is that nobody felt responsible for
> applying it, between the networking (which originally
> added the infrastructure) and kbuild maintainers (Masahiro
> did the last changes to this bit, but recently handed
> over maintenance to Nathan).
Yeah, that seems likely. For the record, I would not have felt
responsible for this code even if it was Cc'd to me since this does not
read as Kbuild material to me.
> I've applied the fix to the asm-generic tree for 6.18 now
> to be sure that it makes it in and gets linux-next testing,
> but it's not my area either really.
>
> It would be best to have another review though. If Nathan
> or Andrew want to instead pick it up through one of their
> trees, please add
>
> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
I do not have a strong opinion on whether you or Andrew take it (I think
it makes sense either way) but I do not think it makes sense for me to
take it via Kbuild.
Cheers,
Nathan