Re: [PATCH] PCI: ixp4xx: Guard ARM32-specific hook_fault_code()

From: Linus Walleij

Date: Tue Sep 30 2025 - 14:59:49 EST


On Thu, Sep 25, 2025 at 10:27 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:

> From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>
> hook_fault_code() is an ARM32-specific API. Guard it and related code with
> CONFIG_ARM #ifdefs so the driver can be compile tested on other
> architectures.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>

It looks OK to me
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxx>

I see some other ARM32 drivers use it too, but we surely do
not have a arch-agnostic way of handling bus errors so perhaps it
need to be like this.

I think Russell created the fault hooks originally so CC:ing him
in.

Yours,
Linus Walleij