Re: [PATCH v4] net/can/gs_usb: increase max interface to U8_MAX
From: Celeste Liu
Date: Tue Sep 30 2025 - 07:36:36 EST
On 2025-09-30 16:13, Marc Kleine-Budde wrote:
> On 30.09.2025 14:15:47, Celeste Liu wrote:
>> This issue was found by Runcheng Lu when develop HSCanT USB to CAN FD
>> converter[1]. The original developers may have only 3 interfaces device to
>> test so they write 3 here and wait for future change.
>>
>> During the HSCanT development, we actually used 4 interfaces, so the
>> limitation of 3 is not enough now. But just increase one is not
>> future-proofed. Since the channel type in gs_host_frame is u8, just
>> increase interface number limit to max size of u8 safely.
>
> I really like the new approach you've implemented in this patch, but now
> the patch description doesn't match anymore.
The patch description has been reword in v5.
>
> regards,
> Marc
>