Re: [PATCH] clk: fix slab-use-after-free when clk_core_populate_parent_map failed

From: Brian Masney

Date: Tue Sep 30 2025 - 06:23:03 EST


Hi Yun,

On Tue, Sep 30, 2025 at 12:59:14PM +0800, Zhou, Yun wrote:
> Hi Brian,
>
> Thanks for your review.
>
> This defect is caused by multiple reasons, but as you said, the fixes tag is
> not accurate enough.
>
> I think it should be:
>
> Fixes: fc0c209c1 ("clk: Allow parents to be specified without string names")
>
> Do you think so?

Yes, that's what I would make it. With that fixed in a v2, you can add:

Reviewed-by: Brian Masney <bmasney@xxxxxxxxxx>

Also, just a heads up to not top post, and to reply inline next time.

https://subspace.kernel.org/etiquette.html#do-not-top-post-when-replying

Brian