Re: [PATCH] rust: file: add intra-doc link for 'EBADF'

From: Miguel Ojeda

Date: Tue Sep 30 2025 - 05:44:58 EST


On Tue, Sep 30, 2025 at 11:27 AM <djfkvcing117@xxxxxxxxx> wrote:
>
> From: Tong Li <djfkvcing117@xxxxxxxxx>
>
> Suggested-by: Onur Özkan <work@xxxxxxxxxxxxx>
> Link: https://github.com/Rust-for-Linux/linux/issues/1186
> Signed-off-by: Tong Li <djfkvcing117@xxxxxxxxx>

Normally commits cannot have an empty message -- this one is trivial,
so it is not a big deal, but maintainers in general may complain. Up
to them, of course.

What you should normally do is explain the "why" of a change, i.e. why
we want to add an intra-doc link, its benefits.

Other than that, it seems like the formatting is good. If you fix the
From: header, then the From: line in the body is not needed and Git
should not add it anymore, but it is not a blocker.

Thanks!

Cheers,
Miguel