Re: [PATCH v2] pinctrl: renesas: rzg2l: Fix ISEL restore on resume
From: Claudiu Beznea
Date: Tue Sep 30 2025 - 01:33:20 EST
Hi, Geert,
On 9/29/25 15:10, Claudiu Beznea wrote:
>> This conflicts with commit d57183d06851bae4 ("pinctrl: renesas: rzg2l:
>> Drop unnecessary pin configurations"), which I have already queued
>> in renesas-drivers/renesas-pinctrl-for-v6.19. Hence I am replacing
>> the above hunk by:
>>
>> /* Switching to GPIO is not required if reset value is
>> same as func */
>> reg = readb(pctrl->base + PMC(off));
>> - spin_lock_irqsave(&pctrl->lock, flags);
>> + raw_spin_lock_irqsave(&pctrl->lock, flags);
>> pfc = readl(pctrl->base + PFC(off));
>> if ((reg & BIT(pin)) && (((pfc >> (pin * 4)) & PFC_MASK) == func)) {
>> - spin_unlock_irqrestore(&pctrl->lock, flags);
>> + raw_spin_unlock_irqrestore(&pctrl->lock, flags);
>> return;
>> }
>>
>> while applying.
> This is right. Thank you! I'm going to give it also a try (on actual HW) a
> bit later. I'll let you know.
Sorry for the delay, all looks good to me (checked on RZ/G3S).
Thank you,
Claudiu
>
> Thank you,
> Claudiu