Re: [PATCH v4 3/6] nova-core: bitfield: Add support for custom visiblity

[Joel Fernandes]

On 9/29/2025 8:28 AM, Alexandre Courbot wrote:
> On Sun Sep 21, 2025 at 3:22 AM JST, Joel Fernandes wrote:
>> Add support for custom visiblity to allow for users to control visibility
>> of the structure and helpers.
>>
>> Reviewed-by: Elle Rhumsaa <elle@xxxxxxxxxxxxxxxxxxx>
>> Signed-off-by: Joel Fernandes <joelagnelf@xxxxxxxxxx>
> 
> Just one comment below; otherwise
> 
> Reviewed-by: Alexandre Courbot <acourbot@xxxxxxxxxx>

Thanks.

>> @@ -161,8 +164,14 @@ fn from(val: $storage) -> Self {
>>  
>>          #[allow(dead_code)]
>>          impl $name {
>> +            /// Returns the raw underlying value
>> +            #[inline(always)]
>> +            $vis fn raw(&self) -> $storage {
>> +                self.0
>> +            }
>> +
> 
> Why does this new method suddenly appears in this patch?

Actually I've removed this already in v5, sorry about that.
 - Joel