Re: [PATCH bpf-next v2 3/3] selftests/bpf/benchs: Add producer and overwrite bench for ring buffer

[Xu Kuohai]

On 9/20/2025 6:15 AM, Andrii Nakryiko wrote:
> On Fri, Sep 5, 2025 at 8:13 AM Xu Kuohai <xukuohai@xxxxxxxxxxxxxxx> wrote:
> >

[...]

> > -static struct ringbuf_bench *ringbuf_setup_skeleton(void)
> > +static struct ringbuf_bench *ringbuf_setup_skeleton(int bench_prod)
>
> int because C doesn't support bool?...

No special reason, just wrote it like that. I’ll switch it to bool

> but really, do we need another benchmark just to set overwritable
> mode?... can't you adapt existing benchmarks to optionally set
> overwritable mode?

OK, I’ll adapt the existing benchmarks to support it.

> (and please drop sdf@xxxxxxxxxx from CC for the next revision, that
> email doesn't exist anymore)

OK

> [...]