Re: [PATCH] loop: fix backing file reference leak on validation error

[Li Chen]

Hi Erkun,

 ---- On Sun, 28 Sep 2025 09:54:51 +0800  yangerkun <yangerkun@xxxxxxxxxx> wrote --- 
 > 
 > 
 > 在 2025/9/26 20:12, Li Chen 写道:
 > > loop_change_fd() and loop_configure() call loop_check_backing_file()
 > > to validate the new backing file. If validation fails, the reference
 > > acquired by fget() was not dropped, leaking a file reference.
 > > 
 > > Fix this by calling fput(file) before returning the error.
 > > 
 > > Signed-off-by: Li Chen <chenl311@xxxxxxxxxxxxxxx>
 > 
 > You'd better add a fix tag:
 > 
 > Fixes: f5c84eff634b ("loop: Add sanity check for read/write_iter")

Thanks, I would add it in v2.

Regards,
Li