Re: [PATCH 12/15] serial: sc16is7xx: add missing space between macro args (checkpatch)

[Jiri Slaby]

On 24. 09. 25, 17:37, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
>
> Fix the following checkpatch error:
>
>      ERROR: space required after that ',' (ctx:VxV)
>      +#define to_sc16is7xx_one(p,e)...
>
> Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
> ---
>   drivers/tty/serial/sc16is7xx.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index a05be92f7e776..9d04d665ec9ab 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -365,7 +365,7 @@ static struct uart_driver sc16is7xx_uart = {
>   	.nr		= SC16IS7XX_MAX_DEVS,
>   };
>   
> -#define to_sc16is7xx_one(p,e)	((container_of((p), struct sc16is7xx_one, e)))
> +#define to_sc16is7xx_one(p, e)	((container_of((p), struct sc16is7xx_one, e)))

Or perhaps make it type-safe and more obvious by switching it to an inline?

--
js
suse labs