RE: [PATCH v2 1/2] interconnect: qcom: sdx75: Drop QPIC interconnect and BCM nodes

[Lakshmi Sowjanya D (QUIC)]

> -----Original Message-----
> From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> Sent: Friday, September 26, 2025 7:17 PM
> To: manivannan.sadhasivam@xxxxxxxxxxxxxxxx; Georgi Djakov
> <djakov@xxxxxxxxxx>; Rohit Agarwal <quic_rohiagar@xxxxxxxxxxx>; Konrad
> Dybcio <konradybcio@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof
> Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>
> Cc: linux-arm-msm@xxxxxxxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx>; devicetree@xxxxxxxxxxxxxxx; Manivannan
> Sadhasivam <mani@xxxxxxxxxx>; Raviteja Laggyshetty (QUIC)
> <quic_rlaggysh@xxxxxxxxxxx>; Lakshmi Sowjanya D (QUIC)
> <quic_laksd@xxxxxxxxxxx>; stable@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 1/2] interconnect: qcom: sdx75: Drop QPIC
> interconnect and BCM nodes
> 
> On 9/26/25 8:42 AM, Manivannan Sadhasivam via B4 Relay wrote:
> > From: Raviteja Laggyshetty <quic_rlaggysh@xxxxxxxxxxx>
> >
> > As like other SDX SoCs, SDX75 SoC's QPIC BCM resource was modeled as a
> > RPMh clock in clk-rpmh driver. However, for SDX75, this resource was
> > also described as an interconnect and BCM node mistakenly. It is
> > incorrect to describe the same resource in two different providers, as
> > it will lead to votes from clients overriding each other.
> >
> > Hence, drop the QPIC interconnect and BCM nodes and let the clients
> > use clk-rpmh driver to vote for this resource.
> >
> > Without this change, the NAND driver fails to probe on SDX75, as the
> > interconnect sync state disables the QPIC nodes as there were no
> > clients voting for this ICC resource. However, the NAND driver had
> > already voted for this BCM resource through the clk-rpmh driver. Since
> > both votes come from Linux, RPMh was unable to distinguish between
> > these two and ends up disabling the QPIC resource during sync state.
> >
> > Cc: stable@xxxxxxxxxxxxxxx
> > Fixes: 3642b4e5cbfe ("interconnect: qcom: Add SDX75 interconnect
> > provider driver")
> > Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@xxxxxxxxxxx>
> > [mani: dropped the reference to bcm_qp0, reworded description]
> > Signed-off-by: Manivannan Sadhasivam
> > <manivannan.sadhasivam@xxxxxxxxxxxxxxxx>
> > ---
> 
> Too bad no one noticed for the 2 years the platform has been upstream..
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> 
> Konrad

Tested-by: Lakshmi Sowjanya D <quic_laksd@xxxxxxxxxxx>  # on SDX75

Regards,
Lakshmi Sowjanya D