Re: [PATCH 16/20] arm64: dts: qcom: kaanapali: Add QRD board

[Jingyi Wang]

On 9/25/2025 10:15 AM, Dmitry Baryshkov wrote:
> On Wed, Sep 24, 2025 at 05:17:33PM -0700, Jingyi Wang wrote:
>> Add support for Qualcomm Kaanapali QRD board which enables booting to
>> shell with uart console, UFS, PMIC peripherals, bus, SDHCI, remoteprocs,
>> USB, PCIE, WLAN and Bluetooth.
>>
>> Written with help from Jishnu Prakash (added rpmhpd nodes), Nitin Rawat
>> (added ufs), Jyothi Kumar Seerapu(added bus), Ronak Raheja (added USB),
>> Manish Pandey(added SDHCI), Jishnu Prakash(added PMIC), Qiang Yu
>> (added PCIE), Yijie Yang(Added WLAN) and Zijun Hu(Added Bluetooth).
>>
>> Signed-off-by: Jingyi Wang <jingyi.wang@xxxxxxxxxxxxxxxx>
>> ---
>>  arch/arm64/boot/dts/qcom/Makefile          |    1 +
>>  arch/arm64/boot/dts/qcom/kaanapali-qrd.dts | 1212 ++++++++++++++++++++++++++++
>>  2 files changed, 1213 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
>> index 7edfa5fa00fc..da9ef255073c 100644
>> --- a/arch/arm64/boot/dts/qcom/Makefile
>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>> @@ -30,6 +30,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= ipq9574-rdp449.dtb
>>  dtb-$(CONFIG_ARCH_QCOM)	+= ipq9574-rdp453.dtb
>>  dtb-$(CONFIG_ARCH_QCOM)	+= ipq9574-rdp454.dtb
>>  dtb-$(CONFIG_ARCH_QCOM)	+= kaanapali-mtp.dtb
>> +dtb-$(CONFIG_ARCH_QCOM)	+= kaanapali-qrd.dtb
>>  dtb-$(CONFIG_ARCH_QCOM)	+= lemans-evk.dtb
>>  
>>  lemans-evk-camera-csi1-imx577-dtbs	:= lemans-evk.dtb lemans-evk-camera-csi1-imx577.dtbo
>> diff --git a/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts b/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts
>> new file mode 100644
>> index 000000000000..5900812c74a5
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts
>> @@ -0,0 +1,1212 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
> 
> Please sort the nodes in the file. You got two entries for tlmm, for
> example.
> 
will fix

Thanks,
Jingyi

>> +&usb_1 {
>> +	dr_mode = "peripheral";
> 
> Is it?
> 
>> +
>> +	status = "okay";
>> +};
>> +
>> +&usb_1_hsphy {
>> +	vdd-supply = <&vreg_l4f_0p8>;
>> +	vdda12-supply = <&vreg_l1d_1p2>;
>> +
>> +	phys = <&pmih0108_eusb2_repeater>;
>> +
>> +	status = "okay";
>> +};
>> +
>> +&usb_dp_qmpphy {
>> +	vdda-phy-supply = <&vreg_l1d_1p2>;
>> +	vdda-pll-supply = <&vreg_l4f_0p8>;
>> +
>> +	status = "okay";
>> +};
>>
>> -- 
>> 2.25.1
>>
>