Re: [PATCH] f2fs-tools: remove unnecessary alignment for blocks_for_ssa
From: Jaegeuk Kim
Date: Sun Sep 28 2025 - 15:58:53 EST
On 09/24, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@xxxxxxxxxx>
>
> total_valid_blks_available is already a multiple of c.blks_per_seg.
> So, we don't need an additional alignment adjustment.
Can we add ASSERT?
>
> Signed-off-by: Daeho Jeong <daehojeong@xxxxxxxxxx>
> ---
> mkfs/f2fs_format.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c
> index b98976c..55a7505 100644
> --- a/mkfs/f2fs_format.c
> +++ b/mkfs/f2fs_format.c
> @@ -500,8 +500,7 @@ static int f2fs_prepare_super_block(void)
> if (c.feature & F2FS_FEATURE_RO)
> blocks_for_ssa = 0;
> else
> - blocks_for_ssa = total_valid_blks_available /
> - c.blks_per_seg + 1;
> + blocks_for_ssa = total_valid_blks_available / c.blks_per_seg;
>
> set_sb(segment_count_ssa, SEG_ALIGN(blocks_for_ssa));
>
> --
> 2.51.0.536.g15c5d4f767-goog
>