Re: [PATCH] arm64: dts: qcom: x1-dell-thena: remove dp data-lanes

[Dmitry Baryshkov]

On Sat, Sep 27, 2025 at 09:59:00AM +0100, Bryan O'Donoghue wrote:
> On 27/09/2025 04:22, Val Packett wrote:
> > The commit that moved data-lanes into the SoC dtsi (458de5842) got merged
> > in parallel with the Thena dtsi (e7733b42) so these lines remained.
> > 
> > Remove them to enable 4-lane DP on the X1E Dell Inspiron/Latitude.
> > 
> > Fixes: e7733b42111c ("arm64: dts: qcom: Add support for Dell Inspiron 7441 / Latitude 7455")
> > Signed-off-by: Val Packett <val@xxxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi | 2 --
> >   1 file changed, 2 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi b/arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi
> > index d71b67824a99..ef83e87e1b7a 100644
> > --- a/arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/x1-dell-thena.dtsi
> > @@ -1090,7 +1090,6 @@ &mdss_dp0 {
> >   };
> >   &mdss_dp0_out {
> > -	data-lanes = <0 1>;
> >   	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
> >   };
> > @@ -1099,7 +1098,6 @@ &mdss_dp1 {
> >   };
> >   &mdss_dp1_out {
> > -	data-lanes = <0 1>;
> >   	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
> >   };
> 
> You should include those commits in the style of below
> 
> commit df8922afc37aa2111ca79a216653a629146763ad
> Author: Jens Axboe <axboe@xxxxxxxxx>
> Date:   Thu Sep 18 13:59:15 2025 -0600
> 
>     io_uring/msg_ring: kill alloc_cache for io_kiocb allocations
> 
>     A recent commit:
> 
>     fc582cd26e88 ("io_uring/msg_ring: ensure io_kiocb freeing is deferred
> for RCU")
> 
> With that fixed.

I think that's a bit of the overkill. The usual style is:

The commit 0123abcdef01 ("foo: bar baz abc") has broken this-and-that on
my device.....

> 
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>

-- 
With best wishes
Dmitry