Re: [PATCH v5 1/4] ALSA: usb-audio: add two-way convert between name and bit for QUIRK_FLAG_*

[Takashi Iwai]

On Thu, 25 Sep 2025 11:25:16 +0200,
Cryolitia PukNgae via B4 Relay wrote:
> +u32 snd_usb_quirk_flags_from_name(const char *name)
> +{
> +	char *upper;
> +	int i;
> +
> +	upper = kstrdup(name, GFP_KERNEL);
> +
> +	if (!upper)
> +		return 0;
> +
> +	string_upper(upper, upper);
> +
> +	if (!name || !*name)
> +		return 0;
> +
> +	for (i = 0; snd_usb_audio_quirk_flag_names[i]; i++) {
> +		if (strcmp(name, snd_usb_audio_quirk_flag_names[i]) == 0 ||
> +		    strcmp(upper, snd_usb_audio_quirk_flag_names[i]) == 0) {
> +			kfree(upper);
> +			return BIT_U32(i);
> +		}
> +	}
> +
> +	kfree(upper);
> +	return 0;
> +}

I suppose you can write simpler code with strcasecmp().


thanks,

Takashi