Re: [PATCH v1 3/3] scsi: ufs: core: Add OP-TEE based RPMB driver for UFS devices

[Bean Huo]

On Tue, 2025-09-23 at 13:27 -0700, Bart Van Assche wrote:
> On 9/23/25 8:39 AM, Bean Huo wrote:
> > +       ret = scsi_execute_cmd(sdev, cdb, send ? REQ_OP_DRV_OUT :
> > REQ_OP_DRV_IN,
> > +                              buffer, len,  /*timeout=*/30 * HZ, 0, NULL);
> > +       return ret <= 0 ? ret : -EIO;
> 
> scsi_execute_cmd() can return a negative value, zero, or a positive
> value. Both negative and positive values should be considered as an
> error.
> 
> > +MODULE_DESCRIPTION("UFS RPMB integration into the RPMB framework using SCSI
> > Secure In/Out");
> 
> That's a very long module description ... Can this description be made
> shorter without reducing clarity?
> 
> > +       u8 rpmb_region0_size;
> > +       u8 rpmb_region1_size;
> > +       u8 rpmb_region2_size;
> > +       u8 rpmb_region3_size;
> 
> Why four separate members instead of an array?
> 
> Thanks,
> 
> Bart.

Bart, 

thanks, we will fix them in next version.

Kind regards,
Bean