Re: [PATCH v3 07/10] phy: qualcomm: qmp-combo: Update QMP PHY with Glymur settings

[Wesley Cheng]

On 9/25/2025 7:11 PM, Dmitry Baryshkov wrote:
> On Thu, Sep 25, 2025 at 05:14:30PM -0700, Wesley Cheng wrote:
> > On 9/24/2025 7:54 PM, Dmitry Baryshkov wrote:
> > > On Wed, Sep 24, 2025 at 07:28:47PM -0700, Wesley Cheng wrote:
> > > > For SuperSpeed USB to work properly, there is a set of HW settings that
> > > > need to be programmed into the USB blocks within the QMP PHY.  Ensure that
> > > > these settings follow the latest settings mentioned in the HW programming
> > > > guide.  The QMP USB PHY on Glymur is a USB43 based PHY that will have some
> > > > new ways to define certain registers, such as the replacement of TXA/RXA
> > > > and TXB/RXB register sets.  This was replaced with the LALB register set.
> > > >
> > > > There are also some PHY init updates to modify the PCS MISC register space.
> > > > Without these, the QMP PHY PLL locking fails.
> > > >
> > > > Signed-off-by: Wesley Cheng <wesley.cheng@xxxxxxxxxxxxxxxx>
> > > > ---
> > > >    drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 311 +++++++++++++++++++++-
> > > >    drivers/phy/qualcomm/phy-qcom-qmp.h       |   4 +
> > > >    2 files changed, 314 insertions(+), 1 deletion(-)
> > > >
> > > > +
> > > > +static const struct qmp_phy_init_tbl glymur_usb43dp_pcs_misc_tbl[] = {
> > > > +	QMP_PHY_INIT_CFG(QPHY_V4_PCS_MISC_PCS_MISC_CONFIG1, 0x01),
> > >
> > > Why is this V4 all of sudden?
> >
> > Hi Dmitry,
> >
> > Will fix..
> >
> > > > +};
> > > > +
> > > > +static const struct qmp_phy_init_tbl glymur_usb43dp_pcs_tbl[] = {
> > > > +	QMP_PHY_INIT_CFG(QPHY_V8_USB43_PCS_LOCK_DETECT_CONFIG1, 0xc4),
> > > > +	QMP_PHY_INIT_CFG(QPHY_V8_USB43_PCS_LOCK_DETECT_CONFIG2, 0x89),
> > > > +	QMP_PHY_INIT_CFG(QPHY_V8_USB43_PCS_LOCK_DETECT_CONFIG3, 0x20),
> > > > +	QMP_PHY_INIT_CFG(QPHY_V8_USB43_PCS_LOCK_DETECT_CONFIG6, 0x13),
> > > > +	QMP_PHY_INIT_CFG(QPHY_V8_USB43_PCS_REFGEN_REQ_CONFIG1, 0x21),
> > > > +	QMP_PHY_INIT_CFG(QPHY_V8_USB43_PCS_RX_SIGDET_LVL, 0x55),
> > > > +	QMP_PHY_INIT_CFG(QPHY_V8_USB43_PCS_RCVR_DTCT_DLY_P1U2_L, 0xe7),
> > > > +	QMP_PHY_INIT_CFG(QPHY_V8_USB43_PCS_RCVR_DTCT_DLY_P1U2_H, 0x03),
> > > > +	QMP_PHY_INIT_CFG(QPHY_V8_USB43_PCS_TSYNC_RSYNC_TIME, 0xa4),
> > > > +	QMP_PHY_INIT_CFG(QPHY_V8_USB43_PCS_RX_CONFIG, 0x0a),
> > > > +	QMP_PHY_INIT_CFG(QPHY_V8_USB43_PCS_TSYNC_DLY_TIME, 0x04),
> > > > +	QMP_PHY_INIT_CFG(QPHY_V8_USB43_PCS_ALIGN_DETECT_CONFIG1, 0xd4),
> > > > +	QMP_PHY_INIT_CFG(QPHY_V8_USB43_PCS_ALIGN_DETECT_CONFIG2, 0x30),
> > > > +	QMP_PHY_INIT_CFG(QPHY_V8_USB43_PCS_PCS_TX_RX_CONFIG, 0x0c),
> > > > +	QMP_PHY_INIT_CFG(QPHY_V8_USB43_PCS_EQ_CONFIG1, 0x4b),
> > > > +	QMP_PHY_INIT_CFG(QPHY_V8_USB43_PCS_EQ_CONFIG5, 0x10),
> > > > +};
> > > > +
> > > > +static const struct qmp_phy_init_tbl glymur_usb43dp_pcs_usb_tbl[] = {
> > > > +	QMP_PHY_INIT_CFG(QPHY_V8_PCS_USB_LFPS_DET_HIGH_COUNT_VAL, 0xf8),
> > > > +	QMP_PHY_INIT_CFG(QPHY_V8_PCS_USB_RXEQTRAINING_DFE_TIME_S2, 0x07),
> > > > +};
> > > > +
> > > > @@ -1667,6 +1899,12 @@ static struct qmp_regulator_data qmp_phy_vreg_l[] = {
> > > >    	{ .name = "vdda-pll", .enable_load = 36000 },
> > > >    };
> > > > +static struct qmp_regulator_data qmp_phy_vreg_refgen[] = {
> > > > +	{ .name = "vdda-phy", .enable_load = 21800 },
> > > > +	{ .name = "vdda-pll", .enable_load = 36000 },
> > > > +	{ .name = "refgen", .enable_load = 936 },
> > >
> > > Is this a meaningful value?
> >
> > I need to adjust this value.  I just want the load for the regulators to be
> > in HPM, and after taking a look, looks like based on the rpmh regulator
> > table, I need to be voting 35000.
>
> Please provide a value from the platform data rather than just the HPM
> boundary.

OK, I referenced our power grid for the correct Ipeak for that 
particular regulator.  Will update this number accordingly.

Thanks
Wesley Cheng

> > Thanks
> > Wesley Cheng
> >
> > > > +};
> > > > +
> > > >    static const u8 qmp_dp_v3_pre_emphasis_hbr3_hbr2[4][4] = {
> > > >    	{ 0x00, 0x0c, 0x15, 0x1a },
> > > >    	{ 0x02, 0x0e, 0x16, 0xff },