Re: [PATCH 1/2] soc: qcom: ocmem: fix device leak on lookup
From: Brian Masney
Date: Fri Sep 26 2025 - 17:08:47 EST
On Fri, Sep 26, 2025 at 04:35:10PM +0200, Johan Hovold wrote:
> Make sure to drop the reference taken to the ocmem platform device when
> looking up its driver data.
>
> Note that holding a reference to a device does not prevent its driver
> data from going away so there is no point in keeping the reference.
>
> Also note that commit 0ff027027e05 ("soc: qcom: ocmem: Fix missing
> put_device() call in of_get_ocmem") fixed the leak in a lookup error
> path, but the reference is still leaking on success.
>
> Fixes: 88c1e9404f1d ("soc: qcom: add OCMEM driver")
> Cc: stable@xxxxxxxxxxxxxxx # 5.5: 0ff027027e05
> Cc: Brian Masney <bmasney@xxxxxxxxxx>
> Cc: Miaoqian Lin <linmq006@xxxxxxxxx>
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
Reviewed-by: Brian Masney <bmasney@xxxxxxxxxx>