Re: [PATCH v3 1/4] ARM: dts: mediatek: drop wrong syscon hifsys compatible for MT2701/7623

[Bjorn Helgaas]

On Thu, Sep 25, 2025 at 06:23:15PM +0200, Christian Marangi wrote:
> The syscon compatible for the hifsys node for Mediatek MT2701/MT7623 SoC
> was wrongly added following the pattern of other clock node but it's
> actually not needed as the register are not used by other device on the
> SoC.
> 
> On top of this it does against the schema for hifsys amnd cause
> dtbs_check warning.

s/does/<something else, not sure what you mean>/
s/amnd/and/ ?
s/cause/causes a/

> Drop the "syscon" compatible to mute the warning and reflect the
> compatible property described in the mediatek,mt2701-hifsys.yaml schema.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> ---
>  arch/arm/boot/dts/mediatek/mt2701.dtsi | 2 +-
>  arch/arm/boot/dts/mediatek/mt7623.dtsi | 3 +--
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/mediatek/mt2701.dtsi b/arch/arm/boot/dts/mediatek/mt2701.dtsi
> index ce6a4015fed5..128b87229f3d 100644
> --- a/arch/arm/boot/dts/mediatek/mt2701.dtsi
> +++ b/arch/arm/boot/dts/mediatek/mt2701.dtsi
> @@ -597,7 +597,7 @@ larb1: larb@16010000 {
>  	};
>  
>  	hifsys: syscon@1a000000 {
> -		compatible = "mediatek,mt2701-hifsys", "syscon";
> +		compatible = "mediatek,mt2701-hifsys";
>  		reg = <0 0x1a000000 0 0x1000>;
>  		#clock-cells = <1>;
>  		#reset-cells = <1>;
> diff --git a/arch/arm/boot/dts/mediatek/mt7623.dtsi b/arch/arm/boot/dts/mediatek/mt7623.dtsi
> index fd7a89cc337d..4b1685b93989 100644
> --- a/arch/arm/boot/dts/mediatek/mt7623.dtsi
> +++ b/arch/arm/boot/dts/mediatek/mt7623.dtsi
> @@ -744,8 +744,7 @@ vdecsys: syscon@16000000 {
>  
>  	hifsys: syscon@1a000000 {
>  		compatible = "mediatek,mt7623-hifsys",
> -			     "mediatek,mt2701-hifsys",
> -			     "syscon";
> +			     "mediatek,mt2701-hifsys";
>  		reg = <0 0x1a000000 0 0x1000>;
>  		#clock-cells = <1>;
>  		#reset-cells = <1>;
> -- 
> 2.51.0
>