Re: [PATCH v2 1/2] ASoC: tas2781: Add tas5828 support

[Takashi Iwai]

On Fri, 26 Sep 2025 06:33:38 +0200,
Baojun Xu wrote:
> 
> TAS5828 have on-chip DSP without current/voltage feedback.
> 
> Signed-off-by: Baojun Xu <baojun.xu@xxxxxx>

Please use a different subject for each patch.  Both patches are 100%
identical subject, and that makes harder to identify.


thanks,

Takashi

> 
> ---
> v2:
>  - Update description for TAS5828
>  - Change commit tree to .../tiwai/sound.git.
> ---
>  include/sound/tas2781.h        | 1 +
>  sound/soc/codecs/tas2781-i2c.c | 7 ++++++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/include/sound/tas2781.h b/include/sound/tas2781.h
> index ddd997ac3..a37b4d67c 100644
> --- a/include/sound/tas2781.h
> +++ b/include/sound/tas2781.h
> @@ -122,6 +122,7 @@ enum audio_device {
>  	TAS2781,
>  	TAS5825,
>  	TAS5827,
> +	TAS5828,
>  	TAS_OTHERS,
>  };
>  
> diff --git a/sound/soc/codecs/tas2781-i2c.c b/sound/soc/codecs/tas2781-i2c.c
> index 1539b7088..f62a71dca 100644
> --- a/sound/soc/codecs/tas2781-i2c.c
> +++ b/sound/soc/codecs/tas2781-i2c.c
> @@ -110,6 +110,7 @@ static const struct i2c_device_id tasdevice_id[] = {
>  	{ "tas2781", TAS2781 },
>  	{ "tas5825", TAS5825 },
>  	{ "tas5827", TAS5827 },
> +	{ "tas5828", TAS5828 },
>  	{}
>  };
>  MODULE_DEVICE_TABLE(i2c, tasdevice_id);
> @@ -126,6 +127,7 @@ static const struct of_device_id tasdevice_of_match[] = {
>  	{ .compatible = "ti,tas2781" },
>  	{ .compatible = "ti,tas5825" },
>  	{ .compatible = "ti,tas5827" },
> +	{ .compatible = "ti,tas5828" },
>  	{},
>  };
>  MODULE_DEVICE_TABLE(of, tasdevice_of_match);
> @@ -1665,7 +1667,7 @@ static void tasdevice_fw_ready(const struct firmware *fmw,
>  	}
>  	tas_priv->fw_state = TASDEVICE_DSP_FW_ALL_OK;
>  
> -	/* There is no calibration required for TAS5825/TAS5827. */
> +	/* There is no calibration required for TAS5825/TAS5827/TAS5828. */
>  	if (tas_priv->chip_id < TAS5825) {
>  		ret = tasdevice_create_cali_ctrls(tas_priv);
>  		if (ret) {
> @@ -1722,6 +1724,7 @@ static void tasdevice_fw_ready(const struct firmware *fmw,
>  		case TAS2781:
>  		case TAS5825:
>  		case TAS5827:
> +		case TAS5828:
>  			/* If DSP FW fail, DSP kcontrol won't be created. */
>  			tasdevice_dsp_remove(tas_priv);
>  		}
> @@ -1884,6 +1887,7 @@ static int tasdevice_codec_probe(struct snd_soc_component *codec)
>  		break;
>  	case TAS5825:
>  	case TAS5827:
> +	case TAS5828:
>  		p = (struct snd_kcontrol_new *)tas5825_snd_controls;
>  		size = ARRAY_SIZE(tas5825_snd_controls);
>  		break;
> @@ -2056,6 +2060,7 @@ static const struct acpi_device_id tasdevice_acpi_match[] = {
>  	{ "TXNW2781", TAS2781 },
>  	{ "TXNW5825", TAS5825 },
>  	{ "TXNW5827", TAS5827 },
> +	{ "TXNW5828", TAS5828 },
>  	{},
>  };
>  
> -- 
> 2.25.1
>