Re: [PATCH] drivers/hwmon/pmbus: Add support for raa229141 in isl68137

[Guenter Roeck]

On 9/25/25 18:45, Jeff Lin wrote:
> In chip RAA229141 there exist ISYS pin which can report the current data
> for the device connected to this chip through this pin by routed by Direct
> Memory Access(DMA) command. To read the data in ISYS pin, we have to set
> the DMA address to 0xC5 and then read the DMA data from 0xC7. And then use
> the Direct read format with 10mA per LSB to transfer the data in 0xC7.
> And for ISYS input pin, the DMA address is 0xE0D3 and for ISYS output pin,
> the DMA address is 0xEE42.
>
> Signed-off-by: Jeff Lin <jefflin994697@xxxxxxxxx>
> ---
...
> diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c
> index c52c55d2e7f4..04a582ba9416 100644
> --- a/drivers/hwmon/pmbus/isl68137.c
> +++ b/drivers/hwmon/pmbus/isl68137.c
> @@ -63,6 +63,9 @@ enum chips {
>   	raa228228,
>   	raa229001,
>   	raa229004,
> ++#if IS_ENABLED(CONFIG_SENSORS_RAA229141)
> ++	raa229141,
> ++#endif /* CONFIG_SENSORS_RAA229141 */

I just realized (as did 0-day): This code doesn't even build.

Obviously that means that I can't trust that the code coming from you actually
works, even if it does build. Please keep that in mind if/when submitting
subsequent versions. I will want to see very detailed and verifiable
information about this chip and its supposed functionality.

Guenter