Re: [PATCH v2 0/5] drm/solomon: Code improvements and DRM helper adoption
From: Javier Martinez Canillas
Date: Fri Sep 26 2025 - 09:15:22 EST
Iker Pedrosa <ikerpedrosam@xxxxxxxxx> writes:
Hello Iker,
> This patch series improves the Solomon SSD130x DRM driver by adopting
> existing DRM helpers, improving code clarity, and following kernel
> coding standards.
>
> * Patch #1 moves DRM GEM framebuffer CPU access calls to make critical
> sections more visible and maintainable.
> * Patch #2 replaces WARN_ON with drm_WARN_ON_ONCE to prevent log spam.
> * Patch #3 adopts drm_crtc_helper_mode_valid_fixed() for mode
> validation.
> * Patch #4 adopts drm_connector_helper_get_modes_fixed() for mode
> management.
> * Patch #5 enforces one assignment per line per kernel coding style.
>
> These improvements reduce code duplication by leveraging existing DRM
> infrastructure and enhance code readability without changing
> functionality.
>
> Signed-off-by: Iker Pedrosa <ikerpedrosam@xxxxxxxxx>
> ---
> Changes in v2:
> - Use a goto label to ensure drm_dev_exit() is called in the error path
> of drm_gem_fb_begin_cpu_access().
> - Link to v1: https://lore.kernel.org/r/20250912-improve-ssd130x-v1-0-bc9389ed299e@xxxxxxxxx
>
Pushed to drm-misc (drm-misc-next). Thanks!
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat