RE: [PATCH rtw-next] wifi: rtw89: Replace hardcoded strings with helper functions
From: Ping-Ke Shih
Date: Tue Sep 23 2025 - 20:44:03 EST
Yu-Chun Lin <eleanor15x@xxxxxxxxx> wrote:
> On Mon, Sep 22, 2025 at 05:50:50AM +0000, Ping-Ke Shih wrote:
> > Yu-Chun Lin <eleanor15x@xxxxxxxxx> wrote:
> > > Replace hardcoded strings with 'str_on_off()', 'str_enable_disable()',
> > > and 'str_read_write()'.
> > >
> > > The change improves readability and enables potential string deduplication
> > > by the linker, which may slightly reduce binary size.
> >
> > Have you measured the change of binary size? Maybe you can share the result
> > here.
> >
>
> I tested the patch and did not observe any measurable change in the binary size.
> The commit message was refers to the description in string-choice.h:
>
> "3) Deduping by the linker, which results in a smaller binary file."
It might rely on LTO (link-time optimization).