Re: [PATCH] dt-bindings: usb: switch: split out ports definition

[Neil Armstrong]

On 9/30/25 20:43, Dmitry Baryshkov wrote:
> On Tue, Sep 30, 2025 at 07:17:21PM +0200, Neil Armstrong wrote:
> > The ports definition currently defined in the usb-switch.yaml
> > fits standards devices which are either recipient of altmode
> > muxing and orientation switching events or an element of the
> > USB Super Speed data lanes.
> >
> > This doesn't necessarely fit combo PHYs like the Qualcomm
> > USB3/DP Combo which has a different ports representation.
> >
> > Move the ports definition to a separate usb-switch-ports.yaml
> > and reference it next to the usb-switch.yaml, except for
> > the Qualcomm USB3/DP Combo PHY bindings.
>
> Isn't it easier to make QMP PHY use $ref for port nodes instead of allOf
> and keep ports definitions inside the usb-switch schema?

Rob asked to not do that... see https://lore.kernel.org/all/20250905175533.GA1000951-robh@xxxxxxxxxx/

Neil

> > Reported-by: Rob Herring <robh@xxxxxxxxxx>
> > Closes: https://lore.kernel.org/all/175462129176.394940.16810637795278334342.robh@xxxxxxxxxx/
> > Fixes: 3bad7fe22796 ("dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp: Reference usb-switch.yaml to allow mode-switch")
> > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> > ---
> >   .../bindings/phy/fsl,imx8mq-usb-phy.yaml           |  4 +-
> >   .../bindings/phy/samsung,usb3-drd-phy.yaml         |  4 +-
> >   .../devicetree/bindings/usb/fcs,fsa4480.yaml       |  1 +
> >   .../devicetree/bindings/usb/gpio-sbu-mux.yaml      |  1 +
> >   .../devicetree/bindings/usb/nxp,ptn36502.yaml      |  1 +
> >   .../devicetree/bindings/usb/onnn,nb7vpq904m.yaml   |  1 +
> >   .../devicetree/bindings/usb/parade,ps8830.yaml     |  1 +
> >   .../bindings/usb/qcom,wcd939x-usbss.yaml           |  1 +
> >   .../devicetree/bindings/usb/ti,tusb1046.yaml       |  1 +
> >   .../devicetree/bindings/usb/usb-switch-ports.yaml  | 68 ++++++++++++++++++++++
> >   .../devicetree/bindings/usb/usb-switch.yaml        | 52 -----------------
> >   11 files changed, 81 insertions(+), 54 deletions(-)