Re: [PATCH V3 2/2] tty: serial: imx: Add missing wakeup event reporting
From: Jiri Slaby
Date: Mon Sep 29 2025 - 01:58:09 EST
On 25. 09. 25, 17:49, Frank Li wrote:
@@ -2732,10 +2734,14 @@ static void imx_uart_enable_wakeup(struct imx_port *sport, bool on)
ucr1 |= UCR1_RTSDEN;
} else {
ucr1 &= ~UCR1_RTSDEN;
+ wake_active |= !!(usr1 & USR1_RTSD);
I think you miss understand my means. suppose bool type only support
||, &&, ==, !=, !
wake_active = wake_active || (usr1 & USR1_RTSD);
+1 to this. Much easier to understand (for me at least).
thanks,
--
js
suse labs