Re: [PATCH v2] gfs2/sysfs: Replace sprintf/snprintf with sysfs_emit()
From: Utkarsh Singh
Date: Tue Sep 23 2025 - 15:19:07 EST
>> Documentation/filesystems/sysfs.rst mentions that show() should only
>> use sysfs_emit() or sysfs_emit_at() when formatting values returned
>> to user space. This patch updates the GFS2 sysfs interface accordingly.
>>
>> It replaces uses of sprintf() and snprintf() in all *_show() functions
>> with sysfs_emit() to align with current kernel sysfs API best practices.
>
>I've applied that part. I'm not pushing this into the upcoming merge
>window anymore, though.
>
Am I correct in understanding that these changes have already been applied?
If so, could you please advise where I might track them to avoid any
redundant work in the future?
>> It also updates the GFS2_SHOW_UINT macro to use sysfs_emit() instead
>> of snprintf().
>
>Huh, what's that?
>
Sorry for the confusion — that was meant to refer to the `TUNE_ATTR_2`
macro in fs/gfs2/sys.c, which defines the *_show functions for tuning
parameters.
Thanks,
Utkarsh