Re: [PATCH V3 05/20] nvdimm/namespace_label: Add namespace label changes as per CXL LSA v2.1

[Neeraj Kumar]

On 23/09/25 02:48PM, Dave Jiang wrote:
> > +static inline void nsl_set_type(struct nvdimm_drvdata *ndd,
> > +				struct nd_namespace_label *ns_label)
> > +{
> > +	if (ndd->cxl && ns_label)
> > +		uuid_parse(CXL_NAMESPACE_UUID, (uuid_t *) ns_label->cxl.type);
>
> You can do:
> uuid_copy(ns_label->cxl.type, cxl_namespace_uuid);
>
> All the constant UUIDs are preparsed by nd_label_init(). For the entire series you can use those pre-parsed uuid_t and just use uuid_copy() instead of having to do string to uuid_t conversions.
>
> DJ

Yes using preparsed UUID's will help to avoid extra uuid_parse() usage.
Sure, I will fix it accordingly


Regards,
Neeraj