Re: [PATCH 4/8] perf test coresight: Dismiss clang warning for memcpy thread

[Leo Yan]

On Thu, Sep 25, 2025 at 12:38:36PM -0700, Ian Rogers wrote:
> On Thu, Sep 25, 2025 at 3:26 AM Leo Yan <leo.yan@xxxxxxx> wrote:
> >
> > clang-18.1.3 on Ubuntu 24.04.2 reports warning:
> >
> >   memcpy_thread.c:30:1: warning: non-void function does not return a value in all control paths [-Wreturn-type]
> >      30 | }
> >         | ^
> >
> > Dismiss the warning with returning NULL from the thread function.
> >
> > Signed-off-by: Leo Yan <leo.yan@xxxxxxx>
> 
> lgtm, should this be moved into being a perf test workload as in
> tools/perf/tests/workloads/ ?

Now we have four programs under shell folder:

  $ cd linux/tools/perf/tests/shell
  $ find ./ -name *.c -o -name *.S
  ./coresight/unroll_loop_thread/unroll_loop_thread.c
  ./coresight/asm_pure_loop/asm_pure_loop.S
  ./coresight/thread_loop/thread_loop.c
  ./coresight/memcpy_thread/memcpy_thread.c
 
If really do this, can move all programs into folders?

  tools/perf/tests/workloads/       - Common programs
  tools/perf/tests/workloads/arm64  - Arch specific programs

Anyway, this should be a separate series to avoid complexity for
enabling Clang build.

Thanks,
Leo