Re: [PATCH 1/2] bus: mhi: host: Add loopback driver with sysfs interface

From: Markus Elfring

Date: Mon Sep 29 2025 - 05:14:31 EST



> +++ b/drivers/bus/mhi/host/mhi_loopback.c
> @@ -0,0 +1,348 @@

> +static ssize_t start_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf, size_t count)
> +{
> + struct mhi_loopback *mhi_lb = dev_get_drvdata(dev);
> + void *send_buf, *recv_buf;

> + guard(mutex)(&mhi_lb->lb_mutex);

> +free_buf:
> + kfree(send_buf);
> +free_recv_buf:
> + kfree(recv_buf);
> +unlock:
+ mhi_lb->loopback_in_progress = false;
> + return ret;
> +}


Under which circumstances would you become interested to apply an attribute
like “__free(kfree)”?
https://elixir.bootlin.com/linux/v6.17-rc7/source/include/linux/slab.h#L476

Regards,
Markus