[PATCH v3 04/12] ACPI: mipi-disco-img: Do not duplicate rotation info into swnodes
From: Ricardo Ribalda
Date: Fri Sep 26 2025 - 09:11:34 EST
The function v4l2_fwnode_device_parse() is now capable of parsing the
_PLD method, there is no need to duplicate the rotation information in a
swnode.
Reviewed-by: Hans de Goede <hansg@xxxxxxxxxx>
Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
---
drivers/acpi/mipi-disco-img.c | 15 ---------------
include/acpi/acpi_bus.h | 1 -
2 files changed, 16 deletions(-)
diff --git a/drivers/acpi/mipi-disco-img.c b/drivers/acpi/mipi-disco-img.c
index 5b85989f96beeb726f59ac9e12e965a215fb38f6..b58b5ba22a47a4afc5212998074d322f0b7586dc 100644
--- a/drivers/acpi/mipi-disco-img.c
+++ b/drivers/acpi/mipi-disco-img.c
@@ -617,21 +617,6 @@ static void init_crs_csi2_swnodes(struct crs_csi2 *csi2)
adev_fwnode = acpi_fwnode_handle(adev);
- /*
- * If the "rotation" property is not present, but _PLD is there,
- * evaluate it to get the "rotation" value.
- */
- if (!fwnode_property_present(adev_fwnode, "rotation")) {
- struct acpi_pld_info *pld;
-
- if (acpi_get_physical_device_location(handle, &pld)) {
- swnodes->dev_props[NEXT_PROPERTY(prop_index, DEV_ROTATION)] =
- PROPERTY_ENTRY_U32("rotation",
- pld->rotation * 45U);
- kfree(pld);
- }
- }
-
if (!fwnode_property_read_u32(adev_fwnode, "mipi-img-clock-frequency", &val))
swnodes->dev_props[NEXT_PROPERTY(prop_index, DEV_CLOCK_FREQUENCY)] =
PROPERTY_ENTRY_U32("clock-frequency", val);
diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h
index aad1a95e6863d443a45985ba7ec7be4acf8664fe..296716875a3e7977abb7b7dfa89f78664aebd61c 100644
--- a/include/acpi/acpi_bus.h
+++ b/include/acpi/acpi_bus.h
@@ -389,7 +389,6 @@ struct acpi_gpio_mapping;
#define ACPI_DEVICE_SWNODE_PORT_NAME_LENGTH 8
enum acpi_device_swnode_dev_props {
- ACPI_DEVICE_SWNODE_DEV_ROTATION,
ACPI_DEVICE_SWNODE_DEV_CLOCK_FREQUENCY,
ACPI_DEVICE_SWNODE_DEV_LED_MAX_MICROAMP,
ACPI_DEVICE_SWNODE_DEV_FLASH_MAX_MICROAMP,
--
2.51.0.536.g15c5d4f767-goog