Re: [PATCH] mfd: macsmc: Initialize mutex
From: Neal Gompa
Date: Fri Sep 26 2025 - 22:29:09 EST
On Thu, Sep 25, 2025 at 4:33 PM Janne Grunau <j@xxxxxxxxxx> wrote:
>
> Struct apple_smc's mutex was not initialized before use. Surprisingly
> this only resulted in occasional NULL pointer dereferences in
> apple_smc_read() calls from the probe() functions of sub devices.
>
> Fixes: e038d985c9823 ("mfd: Add Apple Silicon System Management Controller")
> Signed-off-by: Janne Grunau <j@xxxxxxxxxx>
> ---
> drivers/mfd/macsmc.c | 1 +
> 1 file changed, 1 insertion(+)
>
LGTM.
Reviewed-by: Neal Gompa <neal@xxxxxxxxx>
--
真実はいつも一つ!/ Always, there's only one truth!