Re: [PATCH 5/6] arm64: dts: qcom: qcm6490-shift-otter: Enable RGB LED

[Konrad Dybcio]

On 10/1/25 10:30 AM, Luca Weiss wrote:
> On Wed Oct 1, 2025 at 10:29 AM CEST, Konrad Dybcio wrote:
>> On 9/30/25 4:32 PM, Luca Weiss wrote:
>>> From: Luca Weiss <luca@xxxxxxxxxxxx>
>>>
>>> Enable the RGB LED connected to the PM7350C (PM8350C).
>>>
>>> Signed-off-by: Luca Weiss <luca@xxxxxxxxxxxx>
>>> Signed-off-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx>
>>> ---
>>>  arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts | 27 ++++++++++++++++++++++++
>>>  1 file changed, 27 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
>>> index 36cc67469615974c193ea3a9db1b2362869d56bb..b4c69dc50ed0f0b3cb45341a01c89210bd261993 100644
>>> --- a/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
>>> +++ b/arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts
>>> @@ -632,6 +632,33 @@ led-0 {
>>>  	};
>>>  };
>>>  
>>> +&pm8350c_pwm {
>>> +	status = "okay";
>>> +
>>> +	multi-led {
>>> +		color = <LED_COLOR_ID_RGB>;
>>> +		function = LED_FUNCTION_STATUS;
>>> +
>>> +		#address-cells = <1>;
>>> +		#size-cells = <0>;
>>> +
>>> +		led@1 {
>>> +			reg = <1>;
>>> +			color = <LED_COLOR_ID_RED>;
>>> +		};
>>> +
>>> +		led@2 {
>>> +			reg = <2>;
>>> +			color = <LED_COLOR_ID_GREEN>;
>>> +		};
>>> +
>>> +		led@3 {
>>> +			reg = <3>;
>>> +			color = <LED_COLOR_ID_BLUE>;
>>> +		};
>>
>> I assume you managed to confirm these mappings are correct.. sometimes
>> they are not what you'd expect
> 
> If you mean, that red == red, green == green and blue == blue, yes. The
> RGB configured from user space matches the color on the LED.

Yeah that's what I meant, thanks

Konrad