Re: [PATCH] mfd: macsmc: Initialize mutex

From: Markus Elfring
Date: Wed Oct 01 2025 - 07:15:39 EST


>>> Struct apple_smc's mutex was not initialized before use. Surprisingly
>>> this only resulted in occasional NULL pointer dereferences in
>>> apple_smc_read() calls from the probe() functions of sub devices.
>>
>> See also:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc7#n94
>
> Provide some context in your own words.

Would contributors like to care more also for the usage of imperative mood
in proposed commit messages?


> Don't expect others to click random links.

Should the mentioned information source be better known since a while?

Regards,
Markus