Re: [PATCH v8 2/6] clk: renesas: rzv2h-cpg: Add support for DSI clocks

From: Geert Uytterhoeven
Date: Wed Oct 01 2025 - 09:17:36 EST


Hi Prabhakar,

On Wed, 1 Oct 2025 at 14:23, Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> On Thu, Sep 11, 2025 at 3:26 PM Tomi Valkeinen
> <tomi.valkeinen+renesas@xxxxxxxxxxxxxxxx> wrote:
> > I still don't see why all the code here has to be in a header file.
> > Usually headers contain only a few lines of inline code. Is there a
> > reason why it's not in a .c file?
> >
> Ok, I will move the functions to rzv2h-cpg.c and export the symbols
> and have the declarations in include/linux/clk/renesas.h.
>
> Geert are you OK with the above?

Sure. The DRM driver would already have a hard dependency on the
clock header file anyway.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds