Re: [PATCH v6 5/6] can: mcp251xfd: add gpio functionality

[Bartosz Golaszewski]

On Wed, Oct 1, 2025 at 11:10 AM Viken Dadhaniya
<viken.dadhaniya@xxxxxxxxxxxxxxxx> wrote:
> +
> +       if (!device_property_present(&priv->spi->dev, "gpio-controller"))
> +               return 0;
> +

Hi! I didn't notice this before you're returning 0 here, meaning the
device will be attached to the driver even though it doesn't do
anything. It would make more sense to return -ENODEV.

Bart