Re: [PATCH] slimbus: qcom: remove unused qcom controller driver

From: Rob Herring
Date: Wed Oct 01 2025 - 10:19:24 EST


+Greg

On Fri, Sep 19, 2025 at 12:25 PM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> On Fri, Sep 5, 2025 at 12:30 AM Srinivas Kandagatla <srini@xxxxxxxxxx> wrote:
> >
> >
> >
> > On 9/5/25 12:08 AM, Rob Herring wrote:
> > > On Tue, Aug 19, 2025 at 8:44 AM Srinivas Kandagatla
> > > <srinivas.kandagatla@xxxxxxxxxxxxxxxx> wrote:
> > >>
> > >> Thanks Rob for reporting this,
> > >>
> > >> On 8/19/25 2:35 PM, Rob Herring wrote:
> > >>> On Thu, Jul 24, 2025 at 8:28 AM <srinivas.kandagatla@xxxxxxxxxxxxxxxx> wrote:
> > >>>>
> > >>>> From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxxxxxxxx>
> > >>>>
> > >>>> Qcom Slimbus controller driver is totally unused and dead code, there is
> > >>>> no point in keeping this driver in the kernel without users.
> > >>>>
> > >>>> This patch removes the driver along with device tree bindings.
> > >>>>
> > >>>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxxxxxxxx>
> > >>>> ---
> > >>>> .../bindings/slimbus/qcom,slim.yaml | 86 --
> > >>>> drivers/slimbus/Kconfig | 7 -
> > >>>> drivers/slimbus/Makefile | 3 -
> > >>>> drivers/slimbus/qcom-ctrl.c | 735 ------------------
> > >>>> 4 files changed, 831 deletions(-)
> > >>>> delete mode 100644 Documentation/devicetree/bindings/slimbus/qcom,slim.yaml
> > >>>> delete mode 100644 drivers/slimbus/qcom-ctrl.c
> > >>>
> > >>> This adds warnings to dt_binding_check:
> > >>>
> > >>> Documentation/devicetree/bindings/slimbus/slimbus.example.dtb:
> > >>> /example-0/soc/slim@28080000: failed to match any schema with
> > >>> compatible: ['qcom,apq8064-slim', 'qcom,slim']
> > >>
> > >> Will replace this example with slim-ngd and fold it in the original patch.
> > >
> > > Still warning in linux-next...
> > Its done now!
>
> Now I get this:
>
> Documentation/devicetree/bindings/slimbus/slimbus.example.dtb:
> slim@28080000 (qcom,slim-ngd-v1.5.0): 'audio-codec@1,0' does not match
> any of the regexes: '^pinctrl-[0-9]+$', '^slim@[0-9a-f]+$'
> from schema $id:
> http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml#
> Documentation/devicetree/bindings/slimbus/slimbus.example.dtb:
> slim@28080000 (qcom,slim-ngd-v1.5.0): #address-cells: 1 was expected
> from schema $id:
> http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml#
> Documentation/devicetree/bindings/slimbus/slimbus.example.dtb:
> slim@28080000 (qcom,slim-ngd-v1.5.0): 'dmas' is a required property
> from schema $id:
> http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml#
> Documentation/devicetree/bindings/slimbus/slimbus.example.dtb:
> slim@28080000 (qcom,slim-ngd-v1.5.0): 'dma-names' is a required
> property
> from schema $id:
> http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml#

Still failing in linux-next.

Rob