Re: [PATCH 09/12] unwind: Make unwind_task_info::unwind_mask consistent

[Steven Rostedt]

On Wed, 24 Sep 2025 09:59:57 +0200
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> @@ -324,7 +324,8 @@ void unwind_deferred_cancel(struct unwin
>  	guard(rcu)();
>  	/* Clear this bit from all threads */
>  	for_each_process_thread(g, t) {
> -		clear_bit(bit, &t->unwind_info.unwind_mask);
> +		atomic_long_andnot(UNWIND_USED,
> +				   &t->unwind_info.unwind_mask);

Shouldn't this be:

		atomic_long_andnot(BIT(bit), &t->unwind_info.unwind_mask);

 ?

As BIT(bit) != UNWIND_USED.

-- Steve

>  		if (t->unwind_info.cache)
>  			clear_bit(bit, &t->unwind_info.cache->unwind_completed);
>  	}