Re: [PATCH v3 10/13] gpu: nova-core: gsp: Create RM registry and sysinfo commands

[Timur Tabi]

On Tue, 2025-09-30 at 23:16 +1000, Alistair Popple wrote:
> +pub(crate) fn build_registry(cmdq: &mut Cmdq, bar: &Bar0) -> Result {
> +    let registry = RegistryTable {
> +        entries: [
> +            RegistryEntry {
> +                key: "RMSecBusResetEnable",
> +                value: 1,
> +            },
> +            RegistryEntry {
> +                key: "RMForcePcieConfigSave",
> +                value: 1,
> +            },
> +        ],
> +    };

You forgot to include any of my comments from v2:

https://lore.kernel.org/rust-for-linux/d87bff0c64fb2a549920354c8b09f764e145a492.camel@xxxxxxxxxx/